Testing: Do not configure HttpClient resilience by default #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
DamianEdwards
approved these changes
Apr 19, 2024
DamianEdwards
added
area-app-testing
|
Does this need a corresponding update in docs somewhere? |
|
We don't have docs for this area yet, so kind-of |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8759439359 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is not straightforward to configure resilience policies after the handler has been added (see dotnet/extensions#4814), we decided to remove these from the testing host so that developers are free to choose how resilience is configured in test projects.
cc @DamianEdwards
Fixes #3431
Microsoft Reviewers: Open in CodeFlow