[release/8.0] Fix copy buttons #3584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
approved these changes
Apr 11, 2024
danmoseley
added
Servicing-approved
drewnoakes
approved these changes
Apr 11, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3581 to release/8.0
/cc @JamesNK
Customer Impact
The recently introduced CSP causes copy buttons to fail. They use inline scripts (onclick attribute) which is locked down by CSP.
Fix is to move to a global click event and use event bubbling.
Testing
Manual in Chrome/Edge.
Safari has had different behavior in the past. I'm confident the change here will continue to work in Safari. However, we should get testing in Safari when time is available. I don't think it should block this PR. Worst case, we go from broken for everyone, to broken for Safari. Can improve in the future.
Risk
Low
Regression?
Yes
Microsoft Reviewers: Open in CodeFlow