[release/8.0] Hook which rewrites the container registry in annotations. #3583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
RussKie
approved these changes
Apr 11, 2024
|
@mitchdenny this will get merged once the necessary number of approvals is achieved. |
mitchdenny
approved these changes
Apr 11, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3037 to release/8.0
/cc @mitchdenny
Customer Impact
This was recommended during our threat model reviews to allow people to switch to using an alternate registry for pulling images.
Testing
Added a unit test to cover this scenario and manually tested by creating an app that used a container resource and created an ACR instance and uploaded the image to it and verified that docker pulled from that registry.
Risk
Low. This code only is activated if the
options.ContainerRegistryOverrideproperty is specified.Regression?