Rename DcpServiceName to TargetPortExpression #3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to not leak "DCP" into the public API and keeps DCP-isms contained in the DCP code.
ghost
added
the
area-codeflow
davidfowl
approved these changes
Apr 3, 2024
|
@ReubenBond discovered that #3305 has broken plain Executables using specific port. @eerhardt you might want to coordinate with him on the fix. |
#3372 is the fix for that I believe. Once both our changes are in, we can backport all 3 fixes to preview6. |
eerhardt
added a commit
to eerhardt/aspire
that referenced
this pull request
Apr 5, 2024
This allows us to not leak "DCP" into the public API and keeps DCP-isms contained in the DCP code.
davidfowl
added a commit
that referenced
this pull request
Apr 6, 2024
* Added ability to resolve target port (#3305) * Added ability to resolve target port - Change how we process and expose target ports. This change makes it possible to avoid using any internals of DCP to access and resolve target ports from any resource. - More launch profile processing to the project resource defaults. - Remove logic in the manifest writing that wrote a special env variable. This should just work now like everything else. - Exposed TargetPort and Exists on EndpointReference. - Use this new target property with dapr. - Added a ReferenceExpressionBuilder which makes it possible to dynamically build a ReferenceExpression. - Endpoints and env are evaulated earlier now so change remove tests that add default launch profile on real projects without allocating those endpoints. * Remove more uses of TestProgram * Fix tests * Rename DcpServiceName to TargetPortExpression (#3371) This allows us to not leak "DCP" into the public API and keeps DCP-isms contained in the DCP code. * Do not set TargetPort to Port when IsProxying is also set (#3372) * Do not set TargetPort to Port when IsProxied is true * Move TargetPort check to ApplicationExecutor * Apply port selection logic to manifest publishing (cherry picked from commit 09f5ae9) * Update src/Aspire.Hosting/Dcp/ApplicationExecutor.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> --------- Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> --------- Co-authored-by: David Fowler <davidfowl@gmail.com> Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to not leak "DCP" into the public API and keeps DCP-isms contained in the DCP code.
This is a follow up from #3305 (comment).
Microsoft Reviewers: Open in CodeFlow