Re-focus view button when closing details panel #3368
Conversation
ghost
added
the
| private async Task ClearSelectedResourceAsync() | ||
| { | ||
| SelectedResource = null; | ||
|
|
||
| if (_elementIdBeforeDetailsViewOpened is not null) | ||
| { | ||
| await JS.InvokeVoidAsync("focusElement", _elementIdBeforeDetailsViewOpened); | ||
| } | ||
| } |
There was a problem hiding this comment.
You've changed this so the view button is always focused when the resource is closed, but there are a number of ways to close the resource. For example, if someone changes search parameters on a page then the resource is closed. We don't want to focus the button in that scenario.
What is the exact scenario where the view button should be focused?
There was a problem hiding this comment.
You can check the linked bug, but this is in reaction to the user manually closing the details panel.
You've changed this so the view button is always focused when the resource is closed
Oops, thanks. Fixed
| } | ||
| else | ||
| { | ||
| SelectedResource = resource; | ||
| } | ||
| } | ||
|
|
||
| private void ClearSelectedResource() | ||
| private async Task ClearSelectedResourceAsync(bool causedByUserAction = false) |
There was a problem hiding this comment.
nit: Technically the other ways it gets dismissed are by user actions too (e.g. filtering). Maybe fromExplicitDismiss or something is more accurate?
* Re-focus button when closing details panel * Add internal id for log entries, make sure to null element id on detail view closed * Make sure view button is selected only after a user action --------- Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit e784c91)
* Make sure copy button is tab-accessible and visible on tab (#3192) Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit 2bba2ad) * Avoid reconnection modal taking up entire screen, not being able to i… (#3189) * Avoid reconnection modal taking up entire screen, not being able to interact with page * add slight padding, shadow --------- Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit 87fab1e) * Force log level select position to be below (#3406) Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit 5a6856d) * Re-focus view button when closing details panel (#3368) * Re-focus button when closing details panel * Add internal id for log entries, make sure to null element id on detail view closed * Make sure view button is selected only after a user action --------- Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit e784c91)
Fixes #3362 - this will have to be changed when we remove the view buttons
Microsoft Reviewers: Open in CodeFlow