Publish build assets in the build stage #3334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-codeflow
RussKie
added
the
area-engineering-systems
|
Build doesn't look quite right. Let me investigate. |
|
@RussKie you need to add publishAssetsImmediately to the jobs.yml template parameter set: https://github.com/dotnet/aspire/pull/3334/files#diff-05b01f3df74638712b635c705c3af6dcdaf5e3aa2d40579e7af8d75588a0cd81R127 |
|
Take two - removing the post build job as it's not doing anything. An internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2420590&view=results |
mmitche
approved these changes
Apr 2, 2024
|
Thank you @mmitche |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per offline discussion with @mmitche. This is a build optimisation.
Before 1ES:
With 1ES:
After:
Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2419842&view=logs&j=d17d50ef-afac-5d4b-95a6-3014ce5cf7a4&t=95fe4740-169e-5ca1-2f88-330db40deac4
Microsoft Reviewers: Open in CodeFlow