Fix ConfigurationSchemaGenerator to use correct TimeSpan format #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'duration' isn't an acceptable description of how to represent a TimeSpan. Instead use a custom regular expression to represent TimeSpan formats.
ghost
added
the
area-integrations
sebastienros
approved these changes
Apr 1, 2024
eiriktsarpalis
approved these changes
Apr 2, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8528020180 |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Apr 3, 2024
…et#3320) * Fix ConfigurationSchemaGenerator to use correct TimeSpan format 'duration' isn't an acceptable description of how to represent a TimeSpan. Instead use a custom regular expression to represent TimeSpan formats. * Add tests for the timespan regex. * Fix outdated JSON config schema tests * Fix more tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigurationBinder source generator uses
TimeSpan.Parse(value, CultureInfo.InvariantCulture)to parse TimeSpans.'duration' isn't an acceptable description of how to represent a TimeSpan. Instead use a custom regular expression to represent TimeSpan formats.
Microsoft Reviewers: Open in CodeFlow