Automatically AddAzureProvisioning when Azure resource type is used. #3251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-app-model
10 tasks
davidfowl
changed the title
davidfowl
reviewed
Mar 28, 2024
davidfowl
reviewed
Mar 28, 2024
src/Aspire.Hosting.Azure/Provisioning/Provisioners/BicepProvisioner.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Mar 28, 2024
|
We need AddBicep** and AddAzureConstruct to also call AddAzureProvisioning |
davidfowl
approved these changes
Mar 28, 2024
|
/backport to release/8.0-preview5 |
|
Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8471077932 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2590
This PR will automatically call
AddAzureProvisioning.This PR also improves the error message if there is a provisioning issue due to missing configuration data.
This is what you will now see if a resource fails to provision because it is missing subscription information:
Resources that depend on the resource via enviroment variables have also had some improvements to their error logging:
I haven't removed the exceptions completely on the dependent resources because there are some cases where this could obscure a real issue. So if you turn on debug level logging for DCP you can get the full exception shown (example):
I do not put this debug information in the dashboard (its in the console). This is because the ResourceLoggerService infrastructure doesn't really honor any config settings for controlling verbosity levels. We should probably decide what we want to do here around controlling verbosity of resource loggers.