- 
                Notifications
    You must be signed in to change notification settings 
- Fork 715
Always require OTLP auth mode config when starting dashboard #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| TODO: update standalone dashboard docs and sample | 
| Instead of throwing, can we make it show a page that shows the error and explains what to do? | 
| It's possible, but it would be a lot more work. We'd need to make the new UI. And since the app is starting up in an invalid state, we'd need put checks throughout the app to disable all the other UI and functionality, e.g. ignore incoming OTLP data, don't allow visiting regular UI, hide links to regular UI, don't watch for resources, etc. | 
| Since there is auth for OTLP and auth for the browser, and each has different config settings, it would be annoying to have to explicitly set both to  Maybe there should be a config setting such as  What do you think @drewnoakes @davidfowl? | 
| There are security considerations in having single variable to opt out for all security features. If we add new kinds of security in future, should users that opted out before be automatically opted out of the new security too? The user may have reviewed the decision during installation. They may wish to review newer features as well. If we are going to have a single variable, its name should evoke considerable caution. Something stronger than  | 
| 
 It's not opting out of all security features, just dashboard endpoint authentication. For example, it wouldn't disable configured HTTP security between the dashboard and resource service. What about  | 
d6218c9    to
    7ee2388      
    Compare
  
    03702ce    to
    bc8bd98      
    Compare
  
    
Require OTLP auth mode when starting the dashboard so users must make an explicit decision to have no auth.
@davidfowl FYI, this was review feedback.
Microsoft Reviewers: Open in CodeFlow