Skip to content

Conversation

@radical
Copy link
Member

@radical radical commented Mar 6, 2024

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Mar 6, 2024
@radical radical force-pushed the ef-npgsql branch 2 times, most recently from 3e96af2 to 5f7d71b Compare March 6, 2024 06:28
@radical radical requested review from eerhardt and joperezr March 7, 2024 05:29
@radical radical marked this pull request as ready for review March 7, 2024 05:30
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +32 to +34
if (!resourcesToSkip.Contains(TestResourceNames.efnpgsql))
{
builder.AddNpgsqlDbContext<NpgsqlDbContext>("postgresdb");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One interesting thing here is that if I set "resourcesToSkip" to just have TestResourceNames.postgres, this test is going to fail because there won't be a "postgresdb" connection.

Maybe we should think about just one flag "disableSlowResources", which just turns off Oracle and Cosmos. (Can be a separate PR).

@radical radical merged commit c01d3f6 into dotnet:main Mar 7, 2024
@radical radical deleted the ef-npgsql branch March 7, 2024 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants