Skip to content

Change outgoing request to arrow in trace span #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2024
+26 −7
Merged

Change outgoing request to arrow in trace span #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59d821f
Change outgoing request to arrow in trace span, change uninstrumented…
Jan 17, 2024
e510a7c
change instrumented icon ArrowExportLtr
Jan 17, 2024
597b167
update icons
Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/Aspire.Dashboard/Components/Pages/TraceDetail.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,33 @@
<FluentDataGrid Class="trace-view-grid" ResizableColumns="true" ItemsProvider="@GetData" TGridItem="SpanWaterfallViewModel" RowClass="@GetRowClass" GridTemplateColumns="2fr 6fr">
<TemplateColumn Title="Name">
<div class="col-long-content" title="@context.GetTooltip()" @onclick="() => OnShowProperties(context)">
<span class="span-name-container" style="@($"margin-left: {(context.Depth - 1) * 15}px; border-left-color: {ColorGenerator.Instance.GetColorHexByKey(GetResourceName(context.Span.Source))};")">
@{
var isServerKind = context.Span.Kind == OtlpSpanKind.Server;
var spanNameContainerStyle = $"margin-left: {(context.Depth - 1) * 15}px;";
if (!isServerKind)
{
spanNameContainerStyle += $"border-left-color: {ColorGenerator.Instance.GetColorHexByKey(GetResourceName(context.Span.Source))}; border-left-width: 5px; border-left-style: solid; padding-left: 5px;";
}
}
<span class="span-name-container" style="@spanNameContainerStyle">
@if (isServerKind)
{
<FluentIcon
Class="server-request-icon"
Color="Color.Custom"
CustomColor="@ColorGenerator.Instance.GetColorHexByKey(GetResourceName(context.Span.Source))"
Icon="Icons.Filled.Size16.Server"/>
}

@if (context.IsError)
{
<FluentIcon Icon="Icons.Filled.Size12.ErrorCircle" Color="Color.Error" Class="trace-tag-icon" />
<FluentIcon Icon="Icons.Filled.Size12.ErrorCircle" Color="Color.Error" Class="trace-tag-icon"/>
}
@GetResourceName(context.Span.Source)
@if (context.HasUninstrumentedPeer)
{
<span class="uninstrumented-peer">
<FluentIcon Style="@($"fill: {ColorGenerator.Instance.GetColorHexByKey(context.UninstrumentedPeer)};")" Icon="Icons.Filled.Size16.ArrowCircleRight" Class="uninstrumented-peer-icon" />
<FluentIcon Style="@($"fill: {ColorGenerator.Instance.GetColorHexByKey(context.UninstrumentedPeer)};")" Icon="Icons.Filled.Size16.ArrowCircleRight" Class="uninstrumented-peer-icon"/>
@context.UninstrumentedPeer
</span>
}
Expand Down
10 changes: 6 additions & 4 deletions src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@
}

::deep .span-name-container {
border-left-width: 5px;
border-left-style: solid;
padding-left: 5px;
line-height: 28px;
}

Expand Down Expand Up @@ -132,7 +129,12 @@
}

::deep .uninstrumented-peer {
padding-left: 0.5rem;
padding-left: 0.25rem;
}

::deep .server-request-icon {
margin-right: 3px;
vertical-align: text-bottom;
}

::deep .uninstrumented-peer-icon {
Expand Down