Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 20, 2026

Backport of #13968 to release/13.1

/cc @eerhardt @copilot

Customer Impact

Aspire.Dev is failing to deploy with Aspire 13.1 because it was using a relative path to reference the .bicep file:

https://github.com/microsoft/aspire.dev/blob/44507e3ba297948f7438181a51e28e62e404e7ab/src/apphost/Aspire.Dev.AppHost/Extensions/DeploymentExtensions.cs#L13-L22

I believe the change that caused this issue was: 5b92c02#diff-86b4ae887912c3dbe34b3c97beb99e9b12272fd077b7b57e675818b0a83205b5

Testing

Verified aspire.dev deploys with this change.

Risk

Low - Restores the previous behavior of using the relative path in this scenario. Previously a directory was never provided, which caused the code to return the relative path.

Regression?

Yes

Copilot AI and others added 3 commits January 20, 2026 16:32
- Convert relative template file paths to absolute in constructor
- Copy template files to output directory when directory parameter is provided
- Add test to verify bicep resources with template files can be published

Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
- Don't combine paths if TemplateFile is specified
- Add test to verify bicep resources with template files can be published

Fix #13967
@github-actions
Copy link
Contributor Author

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14018

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14018"

@eerhardt eerhardt added the Servicing-consider Issue for next servicing release review label Jan 20, 2026
This was referenced Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants