-
Notifications
You must be signed in to change notification settings - Fork 800
[release/13.1] Fix AzureBicepResource file-not-found error when using templateFile with AzurePublishingContext #14018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert relative template file paths to absolute in constructor - Copy template files to output directory when directory parameter is provided - Add test to verify bicep resources with template files can be published Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
- Don't combine paths if TemplateFile is specified - Add test to verify bicep resources with template files can be published Fix #13967
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14018Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14018" |
radical
approved these changes
Jan 20, 2026
eerhardt
approved these changes
Jan 20, 2026
This was referenced Feb 11, 2026
This was referenced Feb 12, 2026
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13968 to release/13.1
/cc @eerhardt @copilot
Customer Impact
Aspire.Dev is failing to deploy with Aspire 13.1 because it was using a relative path to reference the .bicep file:
https://github.com/microsoft/aspire.dev/blob/44507e3ba297948f7438181a51e28e62e404e7ab/src/apphost/Aspire.Dev.AppHost/Extensions/DeploymentExtensions.cs#L13-L22
I believe the change that caused this issue was: 5b92c02#diff-86b4ae887912c3dbe34b3c97beb99e9b12272fd077b7b57e675818b0a83205b5
Testing
Verified aspire.dev deploys with this change.
Risk
Low - Restores the previous behavior of using the relative path in this scenario. Previously a
directorywas never provided, which caused the code to return the relative path.Regression?
Yes