Add noProfileSwitch to run command in DotNetCliRunner #11951
Merged
+368
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11951Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11951" |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures consistent profiling behavior across different project types in the .NET CLI runner by adding the noProfileSwitch argument to single-file project runs.
Key Changes
- Updated single-file project run command to include
noProfileSwitchargument, aligning with multi-file project behavior
|
Shouldn't there also be |
|
/backport to release/9.5 |
|
Started backporting to release/9.5: https://github.com/dotnet/aspire/actions/runs/18416092015 |
|
@DamianEdwards backporting to "release/9.5" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Add noProfileSwitch to run command in DotNetCliRunner
Using index info to reconstruct a base tree...
M src/Aspire.Cli/DotNet/DotNetCliRunner.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Cli/DotNet/DotNetCliRunner.cs
CONFLICT (content): Merge conflict in src/Aspire.Cli/DotNet/DotNetCliRunner.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add noProfileSwitch to run command in DotNetCliRunner
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Co-authored-by: Damian Edwards <damian@damianedwards.com>
…ecessary whitespace
captainsafia
approved these changes
Oct 11, 2025
Copilot AI
added a commit
that referenced
this pull request
Oct 11, 2025
…nd and filter empty arguments Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
joperezr
pushed a commit
that referenced
this pull request
Oct 17, 2025
…nner (#11959) * Initial plan * Apply PR #11951 changes: Add noProfileSwitch to single-file run command and filter empty arguments Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted update to the way single-file projects are run in the
DotNetCliRunner. Specifically, it ensures that thenoProfileSwitchargument is included when running single-file projects, aligning the behavior with multi-file project runs.DotNetCliRunner.csto include thenoProfileSwitchargument, ensuring consistent profiling behavior across different project types.