Set up extension build and sign pipeline #11504

adamint · 2025-09-19T03:47:02Z

Description

Adds a new stage that builds, signs, and publishes the extension vsix.

@radical

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire-docs issue (consider using one of the following templates):
- No

This reverts commit 8006a85.

github-actions · 2025-09-19T03:47:11Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11504

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11504"

Copilot

Pull Request Overview

This PR sets up a CI/CD pipeline for building, signing, and publishing the VS Code extension. The changes introduce a new pipeline stage that handles the complete extension build process including dependency installation, localization, packaging, and code signing.

Key changes:

Adds a new "build_sign_extension" stage to the Azure DevOps pipeline that runs before the native build stage
Creates a comprehensive build template for the VS Code extension with Node.js setup, dependency management, and VSIX packaging
Configures code signing for .vsix files using the VsixSHA2 certificate

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
eng/pipelines/azure-pipelines.yml	Adds new pipeline stage for extension build and sign process
eng/pipelines/templates/BuildExtension.yml	Complete build template with Node.js setup, yarn operations, VSIX packaging, and signing
eng/Signing.props	Configures .vsix file signing with VsixSHA2 certificate and includes extension artifacts in signing targets
extension/loc/.gitignore	Removes gitignore entry for xliff directory

eng/pipelines/templates/BuildExtension.yml

eng/pipelines/azure-pipelines.yml

eng/pipelines/templates/BuildExtension.yml

adamint · 2025-09-22T15:52:46Z

https://dnceng.visualstudio.com/internal/_build/results?buildId=2799171&view=results

radical

This is looking good. Just have some feedback.

eng/pipelines/azure-pipelines.yml

eng/pipelines/templates/build-extension.yml

…-loc-build-sign

… extension on the internal pipeline

…y use the exit code to determine success or failure

radical · 2025-09-23T08:42:46Z

internal build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2799854&view=results

.

radical · 2025-09-23T19:05:17Z

extension/Extension.proj

+    <ExtensionSrcDir>$(MSBuildThisFileDirectory)</ExtensionSrcDir>
+  </PropertyGroup>
+
+  <Target Name="BuildAndPackageExtension" BeforeTargets="Build" DependsOnTargets="CheckYarnInstalled;CheckVsceInstalled">


For future PRs it would be useful to add Inputs/Outputs to the targets, so this can be skipped on incremental builds. It would be useful if you are doing it locally.

This reverts commit e178308.

* first try extension CI * move above other stages * install vsce globally before package * explicitly publish extension * try add signing * try #2 * Revert "try #2" This reverts commit 8006a85. * try to fix sign * try with artifacts packages dir property * remove verification * clean up * pr suggestions * run stages in parallel * see if this runs in parallel * add restore back * rename binlog * remove extra upload step * Move building extension to msbuild from the scripts. And always build extension on the internal pipeline * fix typo * fix build * Don't try to parse errors and warnings from yarn/npm invocations. Only use the exit code to determine success or failure * try publishing vsix * update paths * update paths 2 * Revert "update paths 2" This reverts commit e178308. * fix path to publish..? --------- Co-authored-by: Ankit Jain <radical@gmail.com>

…1618) * Initial plan * Set up extension build and sign pipeline (#11504) * first try extension CI * move above other stages * install vsce globally before package * explicitly publish extension * try add signing * try #2 * Revert "try #2" This reverts commit 8006a85. * try to fix sign * try with artifacts packages dir property * remove verification * clean up * pr suggestions * run stages in parallel * see if this runs in parallel * add restore back * rename binlog * remove extra upload step * Move building extension to msbuild from the scripts. And always build extension on the internal pipeline * fix typo * fix build * Don't try to parse errors and warnings from yarn/npm invocations. Only use the exit code to determine success or failure * try publishing vsix * update paths * update paths 2 * Revert "update paths 2" This reverts commit e178308. * fix path to publish..? --------- Co-authored-by: Ankit Jain <radical@gmail.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Adam Ratzman <adam@adamratzman.com> Co-authored-by: Ankit Jain <radical@gmail.com>

joperezr · 2025-09-26T18:55:37Z

eng/common/build.ps1

    /p:Sign=$sign `
    /p:Publish=$publish `
    /p:RestoreStaticGraphEnableBinaryLogger=$binaryLog `
+    /p:BuildExtension=$buildExtension `


This file (and build.sh) shouldn't have been changed for this, as we shouldn't touch files under eng\common. Those get overwritten by arcade each time we update, so this shouldn't be modified, and instead we should change the files under eng\build.ps1/sh. Last night we took an arcade update which broke the build as these scripts where replaced.

cc: @adamint @radical
Fyi: @davidfowl who was asking about this.

I fixed that up in the update-arcade Pr.

adamint added 11 commits September 18, 2025 10:36

first try extension CI

f0f1a7d

move above other stages

c4186d0

install vsce globally before package

5740e21

explicitly publish extension

24c7c40

try add signing

17ee0bf

try #2

8006a85

Revert "try #2"

05676ac

This reverts commit 8006a85.

try to fix sign

e87d402

try with artifacts packages dir property

b6ed70e

remove verification

17a2d4a

clean up

671994f

adamint requested review from Copilot and radical September 19, 2025 03:47

github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Sep 19, 2025

Copilot AI reviewed Sep 19, 2025

View reviewed changes

eng/pipelines/templates/BuildExtension.yml Outdated Show resolved Hide resolved

eng/pipelines/templates/BuildExtension.yml Outdated Show resolved Hide resolved

joperezr reviewed Sep 19, 2025

View reviewed changes

eng/pipelines/azure-pipelines.yml Outdated Show resolved Hide resolved

joperezr reviewed Sep 19, 2025

View reviewed changes

eng/pipelines/templates/BuildExtension.yml Outdated Show resolved Hide resolved

joperezr reviewed Sep 19, 2025

View reviewed changes

eng/pipelines/templates/BuildExtension.yml Outdated Show resolved Hide resolved

radical reviewed Sep 19, 2025

View reviewed changes

eng/pipelines/templates/BuildExtension.yml Outdated Show resolved Hide resolved

radical reviewed Sep 19, 2025

View reviewed changes

eng/pipelines/templates/BuildExtension.yml Outdated Show resolved Hide resolved

adamint added 6 commits September 19, 2025 17:17

pr suggestions

106ed3a

run stages in parallel

fc2f4c1

see if this runs in parallel

131be2c

add restore back

76a9e33

rename binlog

d6d73a3

remove extra upload step

13dfc8a

adamint requested review from joperezr and radical September 22, 2025 15:52

radical previously requested changes Sep 22, 2025

View reviewed changes

dotnet-policy-service bot added the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 22, 2025

radical reviewed Sep 22, 2025

View reviewed changes

eng/pipelines/templates/build-extension.yml Outdated Show resolved Hide resolved

dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Sep 22, 2025

radical added 5 commits September 23, 2025 03:24

Merge remote-tracking branch 'origin/main' into dev/adamint/extension…

36c5577

…-loc-build-sign

Move building extension to msbuild from the scripts. And always build…

e1cd165

… extension on the internal pipeline

fix typo

4d1c4b5

fix build

33131d5

Don't try to parse errors and warnings from yarn/npm invocations. Onl…

98110e7

…y use the exit code to determine success or failure

radical self-requested a review September 23, 2025 08:43

try publishing vsix

ff14ebc

radical reviewed Sep 23, 2025

View reviewed changes

adamint added 4 commits September 23, 2025 16:13

update paths

a85e80c

update paths 2

e178308

Revert "update paths 2"

c929b66

This reverts commit e178308.

fix path to publish..?

5d72d08

radical approved these changes Sep 23, 2025

View reviewed changes

adamint merged commit ad07d53 into dotnet:main Sep 23, 2025
311 checks passed

dotnet-policy-service bot added this to the 9.6 milestone Sep 23, 2025

Copilot AI mentioned this pull request Sep 24, 2025

[release/9.5] Cherry-pick extension build and sign pipeline setup #11618

Merged

joperezr reviewed Sep 26, 2025

View reviewed changes

joperezr mentioned this pull request Sep 26, 2025

Enable building of extensions in the internal build pipeline using property directly instead of switch #11678

Merged

5 tasks

github-actions bot locked and limited conversation to collaborators Oct 27, 2025

Uh oh!

Set up extension build and sign pipeline #11504

Set up extension build and sign pipeline #11504

Conversation

adamint commented Sep 19, 2025

Description

Checklist

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamint commented Sep 22, 2025

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radical commented Sep 23, 2025

Uh oh!

radical Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joperezr Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

radical Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 19, 2025 •

edited

Loading