Run command args should completeley override launch profile args when set

[vmykagapuz]

REGRESSION INFO

1. Worked in Aspire 9.0.0

INSTALL STEPS

1. Clean machine: Win11 x64 23h2
2. Install VS 17.14 P1
3. Install Aspire 9.1.0 GA (Apply Feed)
4. Install Docker/Podman

NOTE

1. This issue reproduces for both 9.0/8.0 framework.

REPRO STEPS

1. Create .NET Aspire Starter App > .NET 9.0 (Standard Term Support) > Aspire 9.1 > Create
2. Right click solution > New project > Azure functions > FunctionApp1 > .NET 9.0 Isolated > Http trigger > Check the "Enlist in Aspire orchestrations > Create.
3. Build and run.

ACTUAL
The "--port 7235" is duplicated

EXPECTED
The text should not be duplicated.

[eerhardt]

cc @captainsafia

[davidfowl]

Also @adamint @JamesNK

[adamint]

@captainsafia I think you need to look at this. The problem occurs in AzureFunctionsProjectResourceExtensions, see below, where a port argument is added to the resource args regardless of whether the launch profile already contains command line args with a port, ie: ("commandLineArgs": "--port 7071"). This can be seen if you run the AzureFunctionsEndToEnd playground app.

 .WithArgs(context =>
            {
                // If we're running in publish mode, we don't need to map the port the host should listen on.
                if (builder.ExecutionContext.IsPublishMode)
                {
                    return;
                }
                var http = resource.GetEndpoint("http");
                context.Args.Add("--port");
                context.Args.Add(http.Property(EndpointProperty.TargetPort));
            })

I'm not sure what solution there is other than updating the project template to remove the commandLineArgs field in launchSettings.json

[davidfowl]

This should be in 9.1 @danmoseley

[davidfowl]

I think this is a bug the app model code we added. If arguments are specified then the launch profile is ignored and the dashboard should reflect that.

@JamesNK this is related to your change