Some parent relationships are not visible in the dashboard

[sebastienros]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

var redis = builder.AddRedis("cache");

var externalService = builder
    .AddExternalService("external-service", "https://microsoft.com")
    .WithParentRelationship(redis);

The relationship is not represented in the resource table:

However the graph shows this is defined:

Expected Behavior

In the dashboard the external service should be displayed as a child of the redis resource.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version info

No response

Anything else?

Aspire 9.4

[davidfowl]

Hmm it should be resolved here

aspire/src/Aspire.Hosting/Orchestrator/ApplicationOrchestrator.cs

Lines 481 to 483 in d621f86

	var parent = resource is IResourceWithParent hasParent
	? hasParent.Parent
	: resource.Annotations.OfType<ResourceRelationshipAnnotation>().LastOrDefault(r => r.Type == KnownRelationshipTypes.Parent)?.Resource;

, maybe something is being overridden.

[MermaidIsla]

Hmm it should be resolved here

aspire/src/Aspire.Hosting/Orchestrator/ApplicationOrchestrator.cs

, maybe something is being overridden.

It actually does get resolved there correctly with redis resource. And it does show in the dashboard if you have unresolved parameters.

But once you fill out the unresolved parameters, the relationship goes away:

[MermaidIsla]

Hmmm further investigation shows that if you attempt to stop the redis resource, it also stops the external resource?

I wonder if this is like the external service accidently gets the id of the redis resource and now it's partially copying what the redis resource has/does.

[davidfowl]

Looks like state corruption.

[MermaidIsla]

There is an infinite recursion/while loop happening on ResourceNotificationService.PublishUpdateAsync with resource external-service after I press Stop on the redis resource. I don't know the source of it yet.

Update: I think this is unrelated to this bug.

[MermaidIsla]

Looks like state corruption.

I think I can actually disprove this because I got down all the way to the DashboardService proto where state updates are being sent and the relationship was still there. Even during the PublishUpdateAsync spam, it was still there but dashboard was showing something else.

I think I can safely say this is probably an issue somewhere in the dashboard.

Update: Nope! I was wrong! It is state corruption.

[MermaidIsla]

Found the problem!

aspire/src/Aspire.Hosting/ExternalServiceBuilderExtensions.cs

Lines 148 to 150 in d621f86

	Properties = [
	new(CustomResourceKnownProperties.Source, uri.Host)
	],

I've actually had this file open like almost the entire time and I was looking at the PublishUpdateAsync call but I completely missed it.