Skip to content

Fix LocProject.json generation file finding bug #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jonfortescue
Copy link
Contributor

This extremely silly bug was found by testing in FSharp. Validated that it doesn't break anything by testing in FSharp, SDK, and winforms.

To double check:

@jonfortescue jonfortescue self-assigned this Mar 23, 2021
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug in a regex? unheard of.

@jonfortescue jonfortescue merged commit 91c8909 into dotnet:main Mar 23, 2021
@jonfortescue jonfortescue deleted the WhoopsFilenamesCanIncludeDots branch March 23, 2021 22:18
akoeplinger pushed a commit to akoeplinger/arcade that referenced this pull request Apr 12, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants