Skip to content

Disable source-link target generation IsSourcePackage=true and DotNetBuildFromSource=true #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

Disable source-link target generation IsSourcePackage=true and DotNetBuildFromSource=true #2867

merged 1 commit into from
May 23, 2019

Conversation

natemcmaster
Copy link
Contributor

When building projects with <IsSourcePackage>true</IsSourcePackage> with /p:DotNetBuildFromSource=true, Arcade fails with

/Users/namc/.nuget/packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19270.1/tools/RepositoryInfo.targets(72,5): error : No SourceRoot with SourceLinkUrl contains directory '/Users/namc/src/aspnet/Extensions/src/Shared/src/ActivatorUtilities'. [/Users/namc/src/aspnet/Extensions/src/Shared/src/ActivatorUtilities/Microsoft.Extensions.ActivatorUtilities.Sources.csproj]

This should resolve it by disabling the _AddSourcePackageSourceLinkFile target.

@natemcmaster natemcmaster requested a review from tmat May 23, 2019 06:52
@natemcmaster
Copy link
Contributor Author

cref dotnet/extensions#1740

@tmat
Copy link
Member

tmat commented May 23, 2019

Thanks!

@natemcmaster natemcmaster merged commit a858f1c into master May 23, 2019
@natemcmaster natemcmaster deleted the namc/sources-and-source-build branch May 23, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemcmaster @tmat