Port PR #16313 vsRequirements refactor to release/8.0 #16314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port changes from PR 16313 to release/8.0 branch
Port PR #16313 vsRequirements refactor to release/8.0
Nov 14, 2025
Copilot finished work on behalf of
marcpopMSFT
November 14, 2025 21:59
Member
|
chcosta is going to try to bake prerelease support configuration for VS into the images so hopefully we don't need this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the defensive null-safety improvements from PR #16313 (release/9.0) to the release/8.0 branch.
Changes
The
LocateVisualStudiofunction ineng/common/tools.ps1now guards against missing global.json properties:$GlobalJson.tools.vsexistence before assignment$vsRequirementsis non-null before accessing.versionand.components-ErrorAction SilentlyContinuetoGet-MembercallsPrevents errors when global.json lacks a
vsnode intoolssection, enabling VS 17.14+ with preview SDK configurations.To double check:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.