Update NuGetRepack to only update version of dependencies from the build #15804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
reviewed
May 5, 2025
| // change to match the platform that is executing. The reference packages that we use to validate | ||
| // the SemVer tests were built on Windows which makes these test only valid for Windows. | ||
| // | ||
| // This can be removed when https://github.com/dotnet/corefx/issues/39931 is fixed. |
Member
There was a problem hiding this comment.
There seems to be workaround: dotnet/runtime#30442 (comment)
tmat
approved these changes
May 5, 2025
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/arcade/actions/runs/14846832089 |
This was referenced May 6, 2025
JoeRobich
added a commit
to dotnet/roslyn
that referenced
this pull request
May 8, 2025
Arcade insertions into the VMR are blocked (see dotnet/dotnet#431) due to Microsoft.CodeAnalysis.Features depending on version 3.3.0 of Microsoft.CodeAnalysis.AnalyzerUtilities instead of the version which builds out of this repo. Previously this had not been a problem as NuGetRepack would rewrite package dependencies with the current build version, but after [a fix in NuGetRepack](dotnet/arcade#15804) to only update package version from the current build, we are correctly referencing the lower package version. This PR changes our package references to M.CA.AnalyzerUtilities to instead be project references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since merging roslyn-analyzers into the roslyn repo, Roslyn packages have been generated that include a dependency on Microsoft.CodeAnalysis.Analyzers (a roslyn-analyzer package) with the wrong version. The packages should depend on version 3.11.0 of the M.CA.Analyzers package but the nuspec is being rewritten to require a M.CA.Analyzers package from the same build. This behavior is due to NuGetRepack only using the package name to determine whether to update a dependency version. This PR additionally validates that the dependency version is from the current build prior to updating.
We can see that although TestPackageA is part of the packages being updated, the dependency in TestPackageG are not update because it is referencing an earlier version. TestPackageB and TestPackageC are updated because they are from the current build.
