Add loose PDB relative blob path #15781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In VMR builds, we do sometimes have multiple legs producing the same pdbs. We do often want to publish those PDBs from multiple legs and there could be overlap in the local symbol path coming out of the build. Ensure we can disambiguate these by prepending the SYSTEM_PHASENAME when available.
|
@ViktorHofer and @jkoritzinsky I'm wondering what you think of this. I don't love it. The other option would be to put the PDBs under Vertical under a similar condition to what we use for the non-rid specific artifacts. BUT, I'm not sure that this would be the right decision. I'm sure some of those PDBs should get published. Furthermore, Extra PDB indexing has less downside than publishing more than one package that has the same ID. |
jkoritzinsky
approved these changes
Apr 25, 2025
|
Damn, I already hit the merge button. @hoyosjs please let us know if this look good to you. |
|
There's an issue with this with the condition. Fixing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VMR builds, we do sometimes have multiple legs producing the same pdbs. We do often want to publish those PDBs from multiple legs and there could be overlap in the local symbol path coming out of the build. Ensure we can disambiguate these by prepending the SYSTEM_PHASENAME when available.
To double check: