Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Jul 19, 2024

No description provided.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@akoeplinger akoeplinger merged commit 3749798 into dotnet:main Jul 22, 2024
@am11 am11 deleted the patch-13 branch July 22, 2024 08:57
jkotas added a commit that referenced this pull request Aug 1, 2024
@jkotas
Copy link
Member

jkotas commented Aug 1, 2024

This change introduced sudden build break: dotnet/runtime#105784

Also, this change goes against principles for deterministic builds: We want the build in a given image to keep working the same way irrespective of the current time.

@am11
Copy link
Member Author

am11 commented Aug 1, 2024

Also, this change goes against principles for deterministic builds: We want the build in a given image to keep working the same way irrespective of the current time.

It was discussed in dotnet/runtime#105129 and it doesn't work that way. We validated it against the CI including wasm leg. That's something which didn't happen during the PR run. I can look into it later today.

@am11
Copy link
Member Author

am11 commented Aug 1, 2024

Leading 0 in calculation was causing that syntax error when script is invoked in pure Unix/POSIX shell: #14985

in https://dev.azure.com/dnceng-public/public/_build/results?buildId=762271&view=logs&jobId=7b499086-9930-5591-220e-2ec7c40eb990&j=7b499086-9930-5591-220e-2ec7c40eb990&t=54e1110f-e31f-5687-a05e-b9730a30a804, the actual wasm mono build passed, but static component build was failing because there we are manually invoking the script from mono.proj. It doesn't run every time, so I think that's how it slipped through the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants