-
Notifications
You must be signed in to change notification settings - Fork 367
Add S.C.I. and S.R.M. dependencies #14377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S.C.I. and S.R.M. dependencies #14377
Conversation
eng/Versions.props
Outdated
@@ -63,11 +63,11 @@ | |||
<MicrosoftiOSTemplatesVersion>15.2.302-preview.14.122</MicrosoftiOSTemplatesVersion> | |||
<MicrosoftiOSTemplatesVersion160527>16.0.527</MicrosoftiOSTemplatesVersion160527> | |||
<!-- Keep this version in sync with what msbuild / VS ships with. --> | |||
<SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion> | |||
<SystemCollectionsImmutableVersion>8.0.0</SystemCollectionsImmutableVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless something has changed after #14115, I think these need to remain at 7.0.0. Is that correct, @ViktorHofer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While VS components (roslyn & msbuild) just recently upgraded to SRM&SCI 8.0.0, the VS installation used i.e. when signing doesn't yet have those changes. So this needs to stay at 7.0.0 for a few more months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so the changes in Versions.props can be reverted and then the values in Version.Details.xml should be for 7.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Will this fix the errors in this PR? dotnet/runtime#97087
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: The "NotSupportedAssemblyGenerator" task failed unexpectedly. [/__w/1/s/artifacts/sb/src/src/libraries/System.IO.Pipes.AccessControl/src/System.IO.Pipes.AccessControl.csproj::TargetFramework=net9.0]
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: System.BadImageFormatException: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Reference assemblies cannot be loaded for execution. (0x80131058) [/__w/1/s/artifacts/sb/src/src/libraries/System.IO.Pipes.AccessControl/src/System.IO.Pipes.AccessControl.csproj::TargetFramework=net9.0]
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: File name: 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' ---> System.BadImageFormatException: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058) [/__w/1/s/artifacts/sb/src/src/libraries/System.IO.Pipes.AccessControl/src/System.IO.Pipes.AccessControl.csproj::TargetFramework=net9.0]
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: File name: 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL' ---> System.BadImageFormatException: Cannot load a reference assembly for execution
No, this change would only impact the behavior of the VMR build. |
OK, I see. I just asked you for help directly in the PR: dotnet/runtime#97087 (comment) |
8a41cd0
to
63fd659
Compare
Fixes dotnet/source-build#3968 by adding System.Collections.Immutable and System.Reflection.Metadata to Version.Details and updating the versions to 8.0.
Build with changes (internal link)