Don't bundle NuGet assemblies in NETCoreApp tasks #13546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
previously approved these changes
May 16, 2023
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
Thanks for fixing this - it was a question I had asked as well.
oleksandr-didyk
previously approved these changes
May 17, 2023
NuGet assemblies are alread bundled into the SDK and therefore don't need to be included in .NETCoreApp msbuild task packages. They need to be kept on .NET Framework which doesn't bundle NuGet along MSBuild. Also fix a version package references using an incorrect NuGet version property.
ViktorHofer
force-pushed
the
DontBundleNuGetAssembliesInNetCoreAppMSBuildTasks
branch
from
8eddee7 to
047d012
Compare
MichaelSimons
approved these changes
May 19, 2023
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build-reference-packages#673 (comment)
NuGet assemblies are alread bundled into the SDK and therefore don't need to be included in .NETCoreApp msbuild task packages.
They need to be kept on .NET Framework which doesn't bundle NuGet along MSBuild.
Also fix a version package references using an incorrect NuGet version property.