-
Notifications
You must be signed in to change notification settings - Fork 375
Add references to newtonsoft.json for transitive version pinning #10126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to newtonsoft.json for transitive version pinning #10126
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
missed some. New test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1898609&view=results |
latest test build is finding some references to |
I think the last few references are coming from the test sdk. There's a newer version uploaded to solve their own newtonsoft dependency issues: https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/17.4.0-preview-20220707-01#dependencies-body-tab Upgrading from our current version means we'll have to update some other dependencies, (or make sure to add newtonsoft references to every test project in the repo) so that might be better left as a separate PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I assume you've built locally and checked out the package cache too?
I talked with Ricardo and I am going to merge this pr to handle the other alerts in other pr |
…net#10126) * Add references to newtonsoft.json for transitive version pinning * but wait.. there's more
part of #10101
Adds references to newtonsoft.json everywhere we need to control transitive pinning.
Running https://dev.azure.com/dnceng/internal/_build/results?buildId=1898566&view=results to see what CG thinks of these changes and whether they are enough.
A lot of the older versions we get through msbuild, which seems like too big of a dependency to just update everywhere, which makes me think the direct references are the best way to go to get this sorted.
To double check: