NUGET_PACKAGES path does not match Visual Studio

[sharwell]

The following line does not end with a trailing \:

arcade/eng/common/tools.ps1

Line 380 in d37430d

$env:NUGET_PACKAGES = Join-Path $env:UserProfile ".nuget\packages"

As a result, the packageFolders entry in project.assets.json changes depending on whether you run a restore operation inside Visual Studio, or via the arcade command line tools.

[tmat]

Sounds like a bug in NuGet. I'd expect NuGet normalize the path and trim the ending backslash.

[markwilkie]

@sharwell - Am I understanding this correctly that the restore works fine from the command line, but not from within VS?

[sharwell]

@markwilkie The restore works fine in both places for the build, but any difference between the two will force the restore process to rewrite the asset file on disk to apply the change.

[tmat]

@rrelyea @nkolev92

[nkolev92]

@tmat
That's something that NuGet can fix.

NuGet normalizes the path, but doesn't trim/append trailing slashes
If fact the trailing slashes is explicitly added in https://github.com/NuGet/NuGet.Client/blob/27af96bdb7ba8d6d7ea9ad53fc76cd1d1aa80703/src/NuGet.Core/NuGet.Configuration/Utility/SettingsUtility.cs#L20

[markwilkie]

Suggestions on next steps @nkolev92 or @rrelyea ?

[nkolev92]

I'd suggest fixing your build infra so that you don't get the extra design time builds anymore.
I have created an issue on our end to address it throughout restore.
NuGet/Home#7968

[markwilkie]

Looks like this is tracking, so am closing the issue. Feel free to reopen of course if needed.