Revert "Unpin darc version" #5657
Conversation
This reverts commit 4cef8e4.
There was a problem hiding this comment.
Pull request overview
This PR reverts changes that unpinned the darc version, temporarily hardcoding it back to version 1.1.0-beta.25522.2 to give repositories time to adopt new Arcade updates. This is a temporary workaround for issue #5443.
- Hardcodes the darc version returned by the
GetDarcVersion()API endpoint instead of dynamically detecting it - Updates PR comment instructions to direct users to install the specific pinned darc version
- Removes unused imports (
System.ReflectionandMicrosoft.DotNet.DarcLib) that were only needed for dynamic version detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ProductConstructionService/ProductConstructionService.Api/Api/v2018_07_16/Controllers/AssetsController.cs |
Comments out dynamic version detection logic and hardcodes darc version to 1.1.0-beta.25522.2; removes now-unused imports |
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestCommentBuilder.cs |
Updates PR comment template to instruct users to install the specific pinned darc version instead of the latest |
| /*AssemblyInformationalVersionAttribute? informationalVersionAttribute = | ||
| typeof(IRemote).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>(); | ||
| var version = informationalVersionAttribute?.InformationalVersion!; | ||
| var lastPlus = version.LastIndexOf('+'); | ||
| if (lastPlus != -1) | ||
| { | ||
| version = version.Substring(0, lastPlus); | ||
| } | ||
| return Ok(version); | ||
| return Ok(version);*/ |
There was a problem hiding this comment.
Commented-out code should be removed rather than left in the codebase. If this code needs to be preserved for reference, it should be tracked through version control history. Keeping large blocks of commented code reduces code maintainability and creates confusion about what is intentional versus temporary.
| return Ok(version); | ||
| return Ok(version);*/ | ||
| // https://github.com/dotnet/arcade-services/issues/5443 - temporary hardcode the version to give repos time to get new arcade | ||
| return Ok("1.1.0-beta.25522.2"); |
There was a problem hiding this comment.
The hardcoded version string "1.1.0-beta.25522.2" creates a maintenance burden. Consider extracting this to a configuration setting or constant at the class level so it can be easily updated when the temporary pin is no longer needed. The GitHub issue reference in the comment is helpful, but a more discoverable location for the version would improve maintainability.
| ``` | ||
| 2. Make sure your `darc` is [up-to-date](https://github.com/dotnet/arcade-services/blob/main/docs/Darc.md#setting-up-your-darc-client) | ||
| *(version {maestroVersion} or higher)* | ||
| 2. ~Make sure your `darc` is [up-to-date](https://github.com/dotnet/arcade-services/blob/main/docs/Darc.md#setting-up-your-darc-client) and run~ |
There was a problem hiding this comment.
The strikethrough markdown should use double tildes (~~) instead of single tilde (~) for proper rendering.
| 2. ~Make sure your `darc` is [up-to-date](https://github.com/dotnet/arcade-services/blob/main/docs/Darc.md#setting-up-your-darc-client) and run~ | |
| 2. ~~Make sure your `darc` is [up-to-date](https://github.com/dotnet/arcade-services/blob/main/docs/Darc.md#setting-up-your-darc-client) and run~~ |
Reverts #5643