Also make sure source repo installation id is there for source code subs #4696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premun
reviewed
Apr 17, 2025
| $"No Maestro GitHub application installation found for repository '{subscription.SourceRepository}'. " + | ||
| "The Maestro github application must be installed by the repository's owner and given access to the repository." | ||
| ])); | ||
| } |
There was a problem hiding this comment.
I think it's better to do what we did in 5e4e719 and just look up the registration during the subscription creation (and fail there if there indeed is no installation present).
There was a problem hiding this comment.
maybe we don't actually need this, I added it to my local when I was running the repro tool on my new devbox and didn't have any repos in there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4426
I excluded non codeflow subscriptions from this PR because in theory they don't need the installation id, and we might be using Maestro somewhere that has this