Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop tracking GitHub bot PAT in secret manifests #4088

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Stop tracking GitHub bot PAT in secret manifests #4088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .vault-config/maestroprod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,3 @@ keys:
size: 2048

importSecretsFrom: shared/maestro-secrets.yaml

secrets:
# Needed during Maestro rollouts to create GitHub releases in arcade-services
BotAccount-dotnet-bot-repo-PAT:
type: github-access-token
parameters:
gitHubBotAccountSecret:
location: engkeyvault
name: BotAccount-dotnet-bot
gitHubBotAccountName: dotnet-bot
7 changes: 0 additions & 7 deletions .vault-config/product-construction-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,6 @@ references:
name: engkeyvault

secrets:
BotAccount-dotnet-bot-repo-PAT:
type: github-access-token
parameters:
gitHubBotAccountSecret:
location: engkeyvault
name: BotAccount-dotnet-bot
gitHubBotAccountName: dotnet-bot

github:
type: github-app-secret
Expand Down
9 changes: 1 addition & 8 deletions .vault-config/product-construction-prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,7 @@ references:
name: engkeyvault

secrets:
BotAccount-dotnet-bot-repo-PAT:
type: github-access-token
parameters:
gitHubBotAccountSecret:
location: engkeyvault
name: BotAccount-dotnet-bot
gitHubBotAccountName: dotnet-bot


github:
type: github-app-secret
parameters:
Expand Down
6 changes: 0 additions & 6 deletions .vault-config/vmr-synchronization.1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,3 @@ secrets:
name: dn-bot-dnceng-build
organizations: dnceng
scopes: build_execute code_write

BotAccount-dotnet-bot-repo-PAT:
type: github-access-token
parameters:
gitHubBotAccountSecret: BotAccount-dotnet-bot
gitHubBotAccountName: dotnet-bot
Loading