Insertion from dotnet/dotnet to MSBuild with that change of encoding for resource file

[YuliiaKovalova]

This morning we received a fresh insertion that contains changes in resources encoding
https://github.com/dotnet/msbuild/pull/12987/files#diff-96445c61fb5eea71d0228cfc2fef869474e32edab0aa4b6b0ae71187324a3192

Is it expected? I don't think it happened before.

[ViktorHofer]

To add, the files in the VMR are stored as "UTF-8 with BOM" and the same files in msbuild are also stored as "UTF-8 with BOM".

[adamzip]

Here's the data I gathered so far
(Sharing with the Product Construction team)

on dotnet/msbuild

• Jan 12, This PR changes the encoding of several files in src/Build/Resources/xlf from UTF8 text to UTF8 (with BOM) text. There are no other changes to the files except the encoding change.
• The very next commit on MSBuild undoes those changes and changes it back to UTF8 with BOM.
• Since then, there have been two backflows from the VMR (one, two), but none of them have made any BOM changes again

on dotnet/dotnet

• It seems that both the flowed commit and the previous one did have the BOM encoding.
• the maestro commit that changed the encoding was not actually the source code update, but the dependency update - which may include merging of branches, so maybe it came from that.
• I tried to gather server logs for the dependency update that brought the BOM changes, but have been unable to find it. Will need to look into this more

[adamzip]

I'm closing this issue because every time we tried to reproduce this scenario, the encoding changes didn't come up. It's not exactly clear what led to this happening or if this will happen again, but we'll be aware of this if it does happen again. Thanks for raising the issue.