Bump to NDK r29 #9926
Open
Bump to NDK r29 #9926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
3 times, most recently
from
6da7fc3 to
4e9f875
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
4e9f875 to
ae6b9ff
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
ae6b9ff to
37037f8
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
37037f8 to
a8c9895
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
a8c9895 to
905abca
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
905abca to
190ef65
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
190ef65 to
d51ab72
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
d51ab72 to
ec292da
Compare
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
2 times, most recently
from
972e2b7 to
fbfb35f
Compare
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9926 in repo dotnet/android |
Member
|
/azp run |
1 similar comment
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
1 similar comment
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
|
/azp run dotnet.android |
|
No pipelines are associated with this pull request. |
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
fbfb35f to
64550d6
Compare
Step 1. Cause breakage
More to face the axe
This should fix NativeAOT builds of multi-project solutions.
…CLR and NativeAOT
grendello
force-pushed
the
dev/grendel/ndk-r29
branch
from
13163d5 to
468f41b
Compare
Comment on lines
+1
to
+7
| # How to update Android NDK | ||
|
|
||
| For the most part, update of the NDK version used to build this repository is | ||
| very straightforward. The only complication arises from the fact that we carry | ||
| a copy of some LLVM source files, for its libc++ and libc++abi libraries. | ||
| The copied files are needed only by the `NativeAOT` host (see https://github.com/dotnet/runtime/issues/121172), | ||
| the `MonoVM` and `CoreCLR` hosts link against the two libraries directly. |
Member
There was a problem hiding this comment.
@grendello just curious, how often should we do this?
Every release? or just every major one?
Contributor
Author
There was a problem hiding this comment.
I tend to track the latest stable release from https://developer.android.com/ndk/downloads/index.html, it is updated every few months.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/android/ndk/wiki/Changelog-r29
Context: dotnet/runtime#121172
Most important changes:
to keep the ability to share code between CoreCLR and NativeAOT hosts.