[Xamarin.Android.Build.Tasks] introduce $(_AndroidJcwCodegenTarget)
#9858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d70db5b was *wrong* in that it merged two different things: * Java stub generation's "codegen target" (now settable by an MSBuild property `$(_AndroidCodeGenerationTarget)`) * C# generator's "codegen target" or `$(AndroidCodegenTarget)` The problem was `$(_AndroidCodeGenerationTarget)` was just poorly named making me think it was the same as `$(AndroidCodegenTarget)`. Partially revert d70db5b and use the name `$(_AndroidJcwCodegenTarget)` instead. NativeAOT now defaults to `$(_AndroidJcwCodegenTarget)=JavaInterop1` and `$(AndroidCodegenTarget)=XAJavaInterop1`.
jonathanpeppers
force-pushed
the
dev/peppers/_AndroidJcwCodegenTarget
branch
from
0b969ba to
307d8e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d70db5b was wrong in that it merged two different things:
Java stub generation's "codegen target" (once settable by an MSBuild property
$(_AndroidCodeGenerationTarget))C# generator's "codegen target" or
$(AndroidCodegenTarget)The problem was
$(_AndroidCodeGenerationTarget)was just poorly named making me think it was the same as$(AndroidCodegenTarget).Partially revert d70db5b and use the name
$(_AndroidJcwCodegenTarget)instead.NativeAOT now defaults to
$(_AndroidJcwCodegenTarget)=JavaInterop1and$(AndroidCodegenTarget)=XAJavaInterop1.