Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xa-prep-tasks] fix build errors for long darc- branch names #9740

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

jonathanpeppers
Copy link
Member

Context: #9732

PR #9732 failed with:

NuGet.Build.Tasks.Pack.targets(221,5): error NU5123: Warning As Error: The file 'package/services/metadata/core-properties/027a96e260344b159133798c830dab61.psmdcp' path, name, or both are too long.
Your package might not work without long file path support. Please shorten the file path or file name.

The branch name is 68 characters long:

darc-release/10.0.1xx-preview1-94740166-a85b-4349-9dd7-c8274168049c

Update the <GitBranch/> MSBuild task to substring long darc- branch names to avoid this problem. I found even 50 characters was causing the issue, so I chose 32.

Context: #9732

PR #9732 failed with:

    NuGet.Build.Tasks.Pack.targets(221,5): error NU5123: Warning As Error: The file 'package/services/metadata/core-properties/027a96e260344b159133798c830dab61.psmdcp' path, name, or both are too long. Your package might not work without long file path support. Please shorten the file path or file name.

The branch name is 68 characters long:

    darc-release/10.0.1xx-preview1-94740166-a85b-4349-9dd7-c8274168049c

Update the `<GitBranch/>` MSBuild task to substring long `darc-`
branch names to avoid this problem. I found even 50 characters was
causing the issue, so I chose 32.
@jonathanpeppers
Copy link
Member Author

One laned timed out, but seems unrelated, going to merge.

@jonathanpeppers jonathanpeppers merged commit 7651b64 into main Feb 3, 2025
56 of 58 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/darc/branch/names branch February 3, 2025 15:04
grendello added a commit that referenced this pull request Feb 3, 2025
* main:
  [NativeAOT] Add support for `Application` subclasses (#9716)
  Bump to dotnet/sdk@d6bc7918c0 10.0.100-preview.2.25102.3 (#9726)
  [xa-prep-tasks] fix build errors for long `darc-` branch names (#9740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants