[trimming] remove our usage of [Preserve]
#9126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
RemovePreserveAttributeUsage
branch
from
23f3ddc to
094909a
Compare
Fixes: dotnet#5197 `[Preserve]` still works in some form, as the `ApplyPreserveAttribute` trimmer step will "mark" types it encounters. It unfortuantely, *does not* work if an assembly is deemed to be fully removed, as the `ApplyPreserveAttribute` will not be called for these types. To better align with the future of .NET, we should remove *our* usage of `[Preserve]`. The only failing result is `Java.Lang.Object.SetHandleOnDeserialized` which can be preserved in `Mono.Android.xml` instead. In a future PR, we can consider emitting warnings in customer code with `[Preserve]` usage.
jonathanpeppers
force-pushed
the
RemovePreserveAttributeUsage
branch
from
094909a to
23ce1f0
Compare
grendello
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5197
[Preserve]still works in some form, as theApplyPreserveAttributetrimmer step will "mark" types it encounters. It unfortuantely, does not work if an assembly is deemed to be fully removed, as theApplyPreserveAttributewill not be called for these types.To better align with the future of .NET, we should remove our usage of
[Preserve]. The only failing result isJava.Lang.Object.SetHandleOnDeserializedwhich can be preserved inMono.Android.xmlinstead.In a future PR, we can consider emitting warnings in customer code with
[Preserve]usage.