-
Notifications
You must be signed in to change notification settings - Fork 552
Enable marshal methods by default, except when Blazor is used #8925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e35296e
Enable marshal methods by default, except when Blazor is used
grendello 6f2371e
Update src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
grendello 8c7aa5d
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 9275fa3
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 6bbcfdb
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 459d4b1
Update apkdesc files
grendello 79d6968
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 5eb2542
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 77cf560
Disable marshal methods when IL stripping is enabled
grendello 9ea817f
Hush MSBuild warnings which break some tests
grendello f89003b
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 8c74570
Update apkdesc
grendello ac317ff
Update apkdesc
grendello 4a6c033
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 54d04f1
Re-enable marshal methods when ILStrip is enabled
grendello 2127b04
Create the stamp dir first
grendello f8d51c7
Merge branch 'main' into dev/grendel/enable-marshal-methods
grendello 705b573
Be careful to touch the stamp file if ILStrip actually ran...
grendello ad416d2
Fix expression syntax
grendello 219ca31
Fix the expression syntax
grendello e779c21
Round and round we go... another syntax fixup
grendello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, what? Why would enabling marshal methods impact
classes.dex
?! I find this deeply concerning. What types are missing due to this change, and why?