Bump external/Java.Interop from c825dca to 56b7eeb
#8748
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [external/Java.Interop](https://github.com/xamarin/java.interop) from `c825dca` to `56b7eeb`. - [Commits](dotnet/java-interop@c825dca...56b7eeb) --- updated-dependencies: - dependency-name: external/Java.Interop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
dellis1972 and
jonathanpeppers
as code owners
|
A newer version of external/Java.Interop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Feb 23, 2024
…1197) Context: dotnet/android#8748 Context: 56b7eeb dotnet/android#8748 attempts to bump xamarin-android to use commit 56b7eeb, and fails to build: (CoreCompile target) -> Xamarin.Android.Build.Tasks\Utilities\MamJsonParser.cs(92,43): error CS0122: 'NotNullWhenAttribute' is inaccessible due to its protection level [Xamarin.Android.Build.Tasks\Xamarin.Android.Build.Tasks.csproj] Xamarin.Android.Build.Tasks\Utilities\MamJsonParser.cs(92,81): error CS0122: 'NotNullWhenAttribute' is inaccessible due to its protection level [Xamarin.Android.Build.Tasks\Xamarin.Android.Build.Tasks.csproj] Xamarin.Android.Build.Tasks\Utilities\MavenExtensions.cs(26,32): error CS0122: 'NotNullWhenAttribute' is inaccessible due to its protection level [Xamarin.Android.Build.Tasks\Xamarin.Android.Build.Tasks.csproj] The cause of the failure is that 56955d9 updated `Java.Interop.Tools.JavaCallableWrappers.csproj` to multitarget both netstandard2.0 and net8.0. This is nominally "fine", except that `Java.Interop.Tools.JavaCallableWrappers.csproj` *also* sets [`$(AppendTargetFrameworkToOutputPath)`][0]=false, which means that both builds use the *same* output directory. This means that the netstandard2.0 and net8.0 build outputs clobber each other -- in parallel! -- which means that the `Xamarin.Android.Build.Tasks.csproj` build doesn't reliably use the netstandard2.0 output assembly. Fix this scenario by no longer overriding the `$(AppendTargetFrameworkToOutputPath)` MSBuild property, and only setting `$(OutputPath)` to `$(ToolOutputFullPath)` for netstandard2.0 builds. Finally, remove use of `XAConfig.props`. This appears to be vestigial, as we can't find any current code that would produce this file. [0]: https://learn.microsoft.com/dotnet/core/project-sdk/msbuild-props#appendtargetframeworktooutputpath
|
@dependabot recreate |
|
Superseded by #8757. |
dependabot
bot
deleted the
dependabot/submodules/external/Java.Interop-56b7eeb
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps external/Java.Interop from
c825dcato56b7eeb.Commits
56b7eeb[Java.Interop.Tools.TypeNameMappings] fix trimmer warnings (#1194)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)