Skip to content

[Xamarin.Android.Build.Tasks] Add check for aapt2 invalid data path error #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[Xamarin.Android.Build.Tasks] Add check for aapt2 invalid data path error #8640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8b5f2
[Xamarin.Android.Build.Tasks] Add check for aapt2 invalid data path e…
dellis1972 Jan 16, 2024
93d901b
Add example
dellis1972 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tasks/Aapt2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,8 @@ static string GetErrorCode (string message)
Tuple.Create ("APT2262", "unexpected element <activity> found in <manifest>"),
Tuple.Create ("APT2263", "found in <manifest>"), // unexpected element <xxxxx> found in <manifest>
Tuple.Create ("APT2264", "The system cannot find the file specified. (2)"), // Windows Long Path error from aapt2
Tuple.Create ("APT2265", "The system cannot find the file specified. (2)") // Windows non-ASCII characters error from aapt2
Tuple.Create ("APT2265", "The system cannot find the file specified. (2)"), // Windows non-ASCII characters error from aapt2
Tuple.Create ("APT2266", "in <data> tag has value of") // error: attribute ‘android:path’ in <data> tag has value of ‘code/fooauth://com.foo.foo, it must start with a leading slash ‘/’.
};
}
}
26 changes: 26 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/ManifestTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,32 @@ public void ApplicationVersionTests (string applicationVersion, bool seperateApk
}
}

[Test]
public void ManifestDataPathError ()
{
var proj = new XamarinAndroidApplicationProject () {
IsRelease = true,
};
var s = proj.AndroidManifest.Replace ("</application>", @"<activity android:name=""net.openid.appauth.RedirectUriReceiverActivity"" android:exported=""true"">
<intent-filter>
<action android:name=""android.intent.action.VIEW""/>
<category android:name=""android.intent.category.DEFAULT""/>
<category android:name=""android.intent.category.BROWSABLE""/>
<data android:path=""code/buildproauth://com.hyphensolutions.buildpro"" android:scheme=""msauth""/>
<data android:path=""callback"" android:scheme=""buildproauth""/>
</intent-filter>
</activity>
</application>");
proj.AndroidManifest = s;
using (var builder = CreateApkBuilder (Path.Combine ("temp", TestContext.CurrentContext.Test.Name))) {
builder.ThrowOnBuildFailure = false;
Assert.IsFalse (builder.Build (proj), "Build should have failed.");
var messages = builder.LastBuildOutput.SkipWhile (x => !x.StartsWith ("Build FAILED.", StringComparison.Ordinal));
string error = messages.FirstOrDefault (x => x.Contains ("error APT2266:"));
Assert.IsNotNull (error, "Warning should be APT2266");
}
}

[Test]
public void ManifestPlaceholders ([Values ("legacy", "manifestmerger.jar")] string manifestMerger)
{
Expand Down