Skip to content

Conversation

@grendello
Copy link
Contributor

@grendello grendello marked this pull request as ready for review July 27, 2023 16:25
@grendello grendello requested a review from jonpryor as a code owner July 27, 2023 16:25
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably want to send this to .NET 7 servicing as well. Any concerns doing that?

@jonpryor
Copy link
Contributor

@jonathanpeppers: no concerns on my end.

@jonpryor
Copy link
Contributor

Bump to xamarin/xamarin-android-binutils/L_16.0.6-6.0.0@b38b5bab (#8220)

Fixes: https://github.com/dotnet/maui/issues/14531

Changes: https://discourse.llvm.org/t/llvm-16-0-0-release/69326
Changes: https://discourse.llvm.org/t/llvm-16-0-1-release/69774
Changes: https://discourse.llvm.org/t/llvm-16-0-2-release/70107
Changes: https://discourse.llvm.org/t/16-0-3-release/70341
Changes: https://discourse.llvm.org/t/16-0-4-release/70692
Changes: https://discourse.llvm.org/t/16-0-5-release/71097
Changes: https://discourse.llvm.org/t/16-0-6-release/71344

Changes: https://github.com/xamarin/xamarin-android-binutils/compare/L_15.0.7-5.0.3...L_16.0.6-6.0.0

  * xamarin/xamarin-android-binutils@b38b5ba: Don't compress Windows binaries with UPX
  * xamarin/xamarin-android-binutils@1ce0b28: Bump XA utils version...
  * xamarin/xamarin-android-binutils@f19d814: Bump LLVM version to 16.0.6 and UPX to 4.0.2
  * xamarin/xamarin-android-binutils@158bbf8: Test build

Bump to an LLVM toolchain based on version 16.0.6.

Additionally, drop use of the UPX executable compressor, since it
appears to be crashing on some Windows machines.
This fixes dotnet/maui#14531.

This in turn means that package and installation sizes will be
larger, but it appears that the Windows NuGet package size only
increases by ~8MB, while the macOS packages are roughly the same.

*Installation* sizes will increase ~2.8x, from ~37.5MB to ~104.6MB
on Windows.

@grendello
Copy link
Contributor Author

@jonathanpeppers net7 should be fine

@jonpryor jonpryor merged commit 76e029f into dotnet:main Jul 27, 2023
@grendello grendello deleted the llvm-16.0.6 branch July 27, 2023 16:57
@jonathanpeppers
Copy link
Member

I'll plan to backport this to .NET 7, once it has been tested/merged by dotnet/maui. 👍

@grendello
Copy link
Contributor Author

@jonathanpeppers if there are any problems compiling native .ll files in NET7, then fc944ee might need to be backported too (it has to do with this transition to opaque pointers in LLVM). If things work in tests, however, we don't need to port the commit.

grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 31, 2023
* main:
  [build] Use .NET preview to create nupkgs (dotnet#8227)
  Bump to xamarin/xamarin-android-binutils/L_16.0.6-6.0.0@b38b5bab (dotnet#8220)
  [ci] Fix MAUI integration test job (dotnet#8221)
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 4, 2023
* main:
  Bump to xamarin/xamarin-android-binutils/L_16.0.6-6.0.0@b38b5bab (dotnet#8220)
  [ci] Fix MAUI integration test job (dotnet#8221)
  [ci] Remove .NET branches from classic release trigger (dotnet#8218)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants