[Xamarin.Android.Build.Tasks] fix .aar files flowing from project references
#8193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences Fixes: dotnet#8190 In a customer sample, they have an `.aar` file they need the Java code from, but do not want a C# binding for it: <AndroidLibrary Update="FooNonBinding-release.aar" Bind="false" /> `Bind="false"` looks to have the side effect where: 1. It does not get copied to the output directory. 2. The Java types don't make it to the final app. 3. Crash at runtime: java.lang.ClassNotFoundException: Didn't find class "com.example.foononbinding.FooSample" on path A workaround is to add a line such as: <None Include="FooNonBinding-release.aar" CopyToOutputDirectory="PreserveNewest" /> I could reproduce this issue by updating our existing `DotNetBuildLibrary` test. I could assert the file exists in the output directory, as well as actually using `dexdump` to verify Java classes make it to the app. They did not! The solution here being that we are missing a line such as: <!-- .aar files should be copied to $(OutputPath) in .NET 6--> ++<None Include="@(AndroidAarLibrary)" TfmSpecificPackageFile="%(AndroidAarLibrary.Pack)" Pack="false" CopyToOutputDirectory="PreserveNewest" Link="%(Filename)%(Extension)" /> <None Include="@(LibraryProjectZip)" TfmSpecificPackageFile="%(LibraryProjectZip.Pack)" Pack="false" CopyToOutputDirectory="PreserveNewest" Link="%(Filename)%(Extension)" /> Now the `DotNetBuildLibrary` test passes.
dellis1972
approved these changes
Jul 18, 2023
jonathanpeppers
added a commit
that referenced
this pull request
Jul 18, 2023
…eferences (#8193) Fixes: #8190 In a customer sample, they have an `.aar` file they need the Java code from, but do not want a C# binding for it: <AndroidLibrary Update="FooNonBinding-release.aar" Bind="false" /> `Bind="false"` looks to have the side effect where: 1. It does not get copied to the output directory. 2. The Java types don't make it to the final app. 3. Crash at runtime: java.lang.ClassNotFoundException: Didn't find class "com.example.foononbinding.FooSample" on path A workaround is to add a line such as: <None Include="FooNonBinding-release.aar" CopyToOutputDirectory="PreserveNewest" /> I could reproduce this issue by updating our existing `DotNetBuildLibrary` test. I could assert the file exists in the output directory, as well as actually using `dexdump` to verify Java classes make it to the app. They did not! The solution here being that we are missing a line such as: <!-- .aar files should be copied to $(OutputPath) in .NET 6--> ++<None Include="@(AndroidAarLibrary)" TfmSpecificPackageFile="%(AndroidAarLibrary.Pack)" Pack="false" CopyToOutputDirectory="PreserveNewest" Link="%(Filename)%(Extension)" /> <None Include="@(LibraryProjectZip)" TfmSpecificPackageFile="%(LibraryProjectZip.Pack)" Pack="false" CopyToOutputDirectory="PreserveNewest" Link="%(Filename)%(Extension)" /> Now the `DotNetBuildLibrary` test passes.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 18, 2023
* main: [Xamarin.Android.Build.Tasks] fix `.aar` files flowing from project references (dotnet#8193)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 18, 2023
* main: [Xamarin.Android.Build.Tasks] fix `.aar` files flowing from project references (dotnet#8193)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8190
In a customer sample, they have an
.aarfile they need the Java code from, but do not want a C# binding for it:Bind="false"looks to have the side effect where:It does not get copied to the output directory.
The Java types don't make it to the final app.
Crash at runtime:
A workaround is to add a line such as:
I could reproduce this issue by updating our existing
DotNetBuildLibrarytest. I could assert the file exists in the output directory, as well as actually usingdexdumpto verify Java classes make it to the app. They did not!The solution here being that we are missing a line such as:
<!-- .aar files should be copied to $(OutputPath) in .NET 6--> ++<None Include="@(AndroidAarLibrary)" TfmSpecificPackageFile="%(AndroidAarLibrary.Pack)" Pack="false" CopyToOutputDirectory="PreserveNewest" Link="%(Filename)%(Extension)" /> <None Include="@(LibraryProjectZip)" TfmSpecificPackageFile="%(LibraryProjectZip.Pack)" Pack="false" CopyToOutputDirectory="PreserveNewest" Link="%(Filename)%(Extension)" />Now the
DotNetBuildLibrarytest passes.