Added AppDomainSetup.set_ShadowCopyDirectories to preserves list #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to fix https://bugzilla.xamarin.com/show_bug.cgi?id=59115 since monodroid_create_appdomain sets this property, expecting it to always be there
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
garuma
approved these changes
Aug 31, 2017
|
build |
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 1, 2017
…net#803) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=59115 `monodroid_create_appdomain()` requires that the `AppDomainSetup.set_ShadowCopyDirectories` property exist, so that it can be called. Unfortunately, the linker may remove this property, which results in a SIGSEGV if it's been removed: C [libmonosgen-2.0.dylib+0x20bc9c] mono_property_set_value+0xc C [libmono-android.debug.dylib+0x154fe] monodroid_property_set+0xbe C [libmono-android.debug.dylib+0x15268] monodroid_create_appdomain+0x248 C [libmono-android.debug.dylib+0xf159] create_domain+0x149 C [libmono-android.debug.dylib+0xe439] create_and_initialize_domain+0x69 C [libmono-android.debug.dylib+0xe89d] Java_mono_android_Runtime_createNewContext+0x7d Add `AppDomainSetup.set_ShadowCopyDirectories` to the linker's preserve list, so that the Android Designer can work as intended.
cobey
added a commit
that referenced
this pull request
Sep 1, 2017
[Xamarin.Android.Build.Tasks] Preserve set_ShadowCopyDirectories (#803)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix https://bugzilla.xamarin.com/show_bug.cgi?id=59115
since monodroid_create_appdomain sets this property, expecting
it to always be there