Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 27, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NETCore.App.Ref: from 8.0.0-preview.4.23221.1 to 8.0.0-preview.4.23225.10 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport: from 8.0.0-preview.4.23218.1 to 8.0.0-preview.4.23219.1 (parent: Microsoft.NETCore.App.Ref)
    • Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.4.23221.1 to 8.0.0-preview.4.23225.10 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.DotNet.Cecil: from 0.11.4-alpha.23178.1 to 0.11.4-alpha.23218.2 (parent: Microsoft.NET.ILLink.Tasks)

From https://github.com/dotnet/installer

  • Subscription: 99acd88a-f058-49d3-c173-08db410efaae
  • Build: 20230428.11
  • Date Produced: April 28, 2023 10:05:15 PM UTC
  • Commit: f8bee7dbc4a2305b96b7023127e143617d023efc
  • Branch: refs/heads/release/8.0.1xx-preview4

…230426.3

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23224.14 -> To Version 8.0.100-preview.4.23226.3

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
 From Version 8.0.0-preview.4.23221.1 -> To Version 8.0.0-preview.4.23225.9 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro bot and others added 3 commits April 28, 2023 12:39
…230427.9

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23224.14 -> To Version 8.0.100-preview.4.23227.9

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
 From Version 8.0.0-preview.4.23221.1 -> To Version 8.0.0-preview.4.23225.9 (parent: Microsoft.Dotnet.Sdk.Internal
…230428.11

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23224.14 -> To Version 8.0.100-preview.4.23228.11

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
 From Version 8.0.0-preview.4.23221.1 -> To Version 8.0.0-preview.4.23225.10 (parent: Microsoft.Dotnet.Sdk.Internal
Comment on lines +52 to +53
"lib/arm64-v8a/libSystem.Globalization.Native.so": {
"Size": 66336
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new, but I think we will just address this in main: #7994 (comment)

It's fine for this extra file to be there in .NET 8 P4.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only test failure is a build performance test: Exceeded expected time of 3000ms, actual 3139.948ms

We should be fine to merge.

@jonathanpeppers jonathanpeppers merged commit 5ca9ebd into release/8.0.1xx-preview4 May 1, 2023
@jonathanpeppers jonathanpeppers deleted the darc-release/8.0.1xx-preview4-767ca97d-8037-4c34-880f-e569c1ca8018 branch May 1, 2023 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants