Skip to content

Test removing 'net472' from Java.Interop. #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Test removing 'net472' from Java.Interop. #7958

wants to merge 3 commits into from

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Apr 13, 2023 •
edited
Loading

Removes monoandroid10 from Mono.Android.dll and friends in order to remove net472 from Java.Interop.

@jpobst jpobst force-pushed the test-ji-net472-removal branch 3 times, most recently from 768e8fd to 93695c0 Compare April 14, 2023 04:35
@jpobst
Copy link
Contributor Author

jpobst commented Apr 17, 2023

@pjcollins I've got this so it successfully builds Xamarin.Android.sln, removing many net472 and monoandroid10 target frameworks.

However, it fails now at running the MDoc process on Mono.Android.dll in create-installers, which is all monoandroid10 based. The logic for this seems pretty complex, and I think I'm gonna need your help to update it to work with .NET.

@pjcollins pjcollins mentioned this pull request Apr 19, 2023
Closed
@pjcollins
Copy link
Member

Added #7974 to track this work for an upcoming sprint.

@jpobst jpobst force-pushed the test-ji-net472-removal branch from 916966a to f33ed8b Compare May 11, 2023 14:34
@jpobst jpobst force-pushed the test-ji-net472-removal branch from 63b48aa to 98f598e Compare May 11, 2023 15:39
@jpobst jpobst closed this May 15, 2023
@jpobst jpobst deleted the test-ji-net472-removal branch May 15, 2023 19:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers jonathanpeppers will be requested when the pull request is marked ready for review jonathanpeppers is a code owner

@grendello grendello Awaiting requested review from grendello grendello will be requested when the pull request is marked ready for review grendello is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpobst @pjcollins