[build] Hush a couple of code analyzer warnings for Mono.Android #7591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building our repo generates around 3400 warnings per single .NET build,
similar to:
warning CA1416: This call site is reachable on: 'Android' 21.0 and later. 'Double' is only supported on: .
warning CA1422: This call site is reachable on: 'Android' 21.0 and later. 'Double' is obsoleted on: 'Android' 33.0 and later.
Since printing each message to the console needs to be synchronized,
that means the build might be slower than necessary, since we generate
over 10k of these messages per CI build.
Disable the warnings by default. They can be enabled by setting the
`$(_EnableCodeAnalyzerPlatformWarnings)` MSBuild property to any value.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Dec 1, 2022
* main: Bump external/Java.Interop from `984711a` to `3a9f770` (dotnet#7592) [Mono.Android] NoWarn CA1416, CA1422 code analyzer warnings (dotnet#7591)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building our repo generates around 3400 warnings per single .NET build, similar to:
Since printing each message to the console needs to be synchronized, that means the build might be slower than necessary, since we generate over 10k of these messages per CI build.
Disable the warnings by default. They can be enabled by setting the
$(_EnableCodeAnalyzerPlatformWarnings)MSBuild property to any value.