Avoid XA5207 for design-time builds #7434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#7405 Raising a XA5207 Error during a design time build is causing some problems for the auto sdk installer. The design time build is run for all frameworks. So you end up in a position when you have the Windows framework selected in the IDE and the auto sdk installer will try to install an Android framework. Its very confusing for the user. So lets not raise this Error during a design time build.
jonathanpeppers
pushed a commit
that referenced
this pull request
Oct 10, 2022
) Fixes: #7405 Raising an XA5207 error during a [design time build][0] in Visual Studio (Windows) can cause problems in the auto sdk installer: error XA5207: Could not find android.jar for API level 31. This means the Android SDK platform for API level 31 is not installed. Either install it in the Android SDK Manager (Tools > Android > Android SDK Manager…), or change the Xamarin.Android project to target an API version that is installed. (C:\Program Files (x86)\Android\android-sdk\platforms\android-31\android.jar missing.) The design time build is run for all frameworks; you can end up in a position where you have the Windows framework selected in the IDE and the auto sdk installer will try to install an Android framework. Its very confusing for the user. Avoid raising error XA5207 during design time builds. [0]: https://github.com/dotnet/project-system/blob/3f5fb23d3fa91719c93b68f56e99aba6b18939aa/docs/design-time-builds.md
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 10, 2022
* main: Enable marshal methods support by default (dotnet#7351) Bump to dotnet/java-interop@e1ee4b1c, xamarin/android-api-docs@bc5443dc (dotnet#7358) [xaprepare] Support Gentoo Linux for OS detection (dotnet#7442) [Xamarin.Android.Build.Tasks] Avoid XA5207 for design-time builds (dotnet#7434) [Mono.Android] Improve generated API docs diff (dotnet#7427) Localized file check-in by OneLocBuild Task: Build definition ID 11410: Build ID 6765281 (dotnet#7430) LEGO: Merge pull request 7429 Bump to dotnet/java-interop@a0728ed5 (dotnet#7420)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 10, 2022
* main: [xaprepare] Support Gentoo Linux for OS detection (dotnet#7442) [Xamarin.Android.Build.Tasks] Avoid XA5207 for design-time builds (dotnet#7434)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7405
Raising a XA5207 Error during a design time build is causing some
problems for the auto sdk installer. The design time build is run for
all frameworks. So you end up in a position when you have the Windows
framework selected in the IDE and the auto sdk installer will try to
install an Android framework. Its very confusing for the user.
So lets not raise this Error during a design time build.