Skip to content

Conversation

@pjcollins
Copy link
Member

The windows-toolchain-pdb artifact has been updated to include a ZIP
containing both PDB and EXE files. This artifact will now be uploaded
to blob storage and included in the nuget-artifacts GitHub status.

These changes will allow the .NET Visual Studio insertion pipeline to
archive the symbols in this zip file, as its symbol archiving step
already has support for processing ZIP files listed in the
nuget-artifacts GitHub status.

The `windows-toolchain-pdb` artifact has been updated to include a ZIP
containing both PDB and EXE files.  This artifact will now be uploaded
to blob storage and included in the `nuget-artifacts` GitHub status.

These changes will allow the .NET Visual Studio insertion pipeline to
archive the symbols in this zip file, as its symbol archiving step
already [has support for processing ZIP files][0] listed in the
`nuget-artifacts` GitHub status.

[0]: https://github.com/xamarin/sdk-insertions/blob/15cc361f17d8c34f208ab8d8be024ba39307b295/templates/common/archive-symbols.yml#L40-L72
@pjcollins pjcollins marked this pull request as ready for review August 18, 2022 21:36
@pjcollins pjcollins merged commit 56a14e5 into dotnet:main Aug 19, 2022
@pjcollins pjcollins deleted the llvm-symbol-zip branch August 19, 2022 14:34
jonathanpeppers pushed a commit that referenced this pull request Aug 19, 2022
The `windows-toolchain-pdb` artifact has been updated to include a ZIP
containing both PDB and EXE files.  This artifact will now be uploaded
to blob storage and included in the `nuget-artifacts` GitHub status.

These changes will allow the .NET Visual Studio insertion pipeline to
archive the symbols in this zip file, as its symbol archiving step
already [has support for processing ZIP files][0] listed in the
`nuget-artifacts` GitHub status.

[0]: https://github.com/xamarin/sdk-insertions/blob/15cc361f17d8c34f208ab8d8be024ba39307b295/templates/common/archive-symbols.yml#L40-L72
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 19, 2022
* main:
  [Xamarin.Android.Build.Tasks, monodroid] LLVM-IR Generator (dotnet#7163)
  $(AndroidPackVersionSuffix)=rc.2; net7 is 33.0.0.rc.2 (dotnet#7283)
  [ci] Add EXE files to windows-toolchain-pdb artifact (dotnet#7279)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants