[build] Version .NET VS manifest file #7064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of supporting .NET 6 projects with our .NET 7 workload, we will want to be able to insert both .NET 6 and .NET 7 workload packs into VS. Historically, we have replaced the [VS manifest file][0] every time we update our workload. For .NET 7 we will likely want two VS manifests side by side, one which contains our .NET 6 packs and one for .NET 7. Add a version to the .NET VS manifest file to support this potential side by side scenario. [0]: https://devdiv.visualstudio.com/DevDiv/_git/VS?path=/.corext/Configs/dotnet-workloads-components.json&version=GBmain&line=10&lineEnd=11&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents
jonathanpeppers
approved these changes
Jun 2, 2022
| <Project> | ||
| <PropertyGroup> | ||
| <TargetName>Microsoft.NET.Sdk.Android.Workload</TargetName> | ||
| <TargetName>Microsoft.NET.Sdk.Android.Workload.@VSMAN_VERSION@</TargetName> |
Member
There was a problem hiding this comment.
So this would be Microsoft.NET.Sdk.Android.Workload.7.0?
That's probably fine, but do we need the .0? If this would never be seen by a customer, probably doesn't matter.
Member
Author
There was a problem hiding this comment.
Yeah I figured most repos would have this 7.0 version and it would avoid any extra trimming efforts, we could maybe change it to Microsoft.NET.Sdk.Android.Workload.net7.0 alternatively.
Contributor
There was a problem hiding this comment.
I like net7.0 as a suffix.
Member
Author
There was a problem hiding this comment.
Agreed, it makes the 7.0 less arbitrary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of supporting .NET 6 projects with our .NET 7 workload, we will
want to be able to insert both .NET 6 and .NET 7 workload packs into VS.
Historically, we have replaced the VS manifest file every time we
update our workload. For .NET 7 we will likely want two VS manifests
side by side, one which contains our .NET 6 packs and one for .NET 7.
Add a version to the .NET VS manifest file to support this potential
side by side scenario.