[Mono.Posix] Mono.Posix.csproj fixes. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building xamarin-android/master with Mono 4.4.0 [0] would result in a build error within `src/Mono.Posix`: CSC: error CS1703: An assembly `System.Runtime' with the same identity has already been imported. Consider removing one of the references. This was introduced by commit f2fed37, which added `System.Runtime` as a `@(Reference)` to `Mono.Posix.csproj`. `Mono.Posix.csproj` `<Import/>`s `Xamarin.Android.CSharp.targets`, which indirectly adds `System.Runtime`, so there is no need for `Mono.Posix.csproj` to directly refernce `System.Runtime`. Additionally, `msbuild` is more stringent regarding property functions and quoting: this resulted in an MSBuild error: Condition="$(AndroidSupportedAbisForConditionalChecks.Contains (:x86:'))"> The fix is to properly quote the `.Contains()` method parameters. Finally, re-order various elements to increase consistency with other projects, e.g. `@(Reference)` should go with other `@(Reference)` entries, `Configuration.props` should be imported as early as possible, `$(TargetFrameworkVersion)` should be set to `$(AndroidFrameworkVersion)` (which requires the earlirer `Configuration.props` import), etc. [0]: mono-4.4.0-branch-c7-baseline/5995f74
| @@ -12,7 +12,12 @@ | |||
| <AndroidResgenClass>Resource</AndroidResgenClass> | |||
| <AndroidResgenFile>Resources\Resource.designer.cs</AndroidResgenFile> | |||
| <AssemblyName>Mono.Posix</AssemblyName> | |||
| <TargetFrameworkVersion>v6.0</TargetFrameworkVersion> | |||
| <SignAssembly>true</SignAssembly> | |||
| <AssemblyOriginatorKeyFile>..\..\product.snk</AssemblyOriginatorKeyFile> | |||
There was a problem hiding this comment.
It does not seem to be in the repo. Do we actually need this?
There was a problem hiding this comment.
nm, it DOES exist, looking at wrong directory.
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Relative paths -- used previously -- have some pros, but one large con: it complicates submodule checkout. For example (I assume?), [on Jenkins][0]: FATAL: Command "git submodule update --init --recursive" returned status code 128: stdout: stderr: Cloning into 'lib/mono.linq.expressions'... Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@github.com:jonpryor/mono.linq.expressions.git' into submodule path 'lib/mono.linq.expressions' failed hudson.plugins.git.GitException: Command "git submodule update --init --recursive" returned status code 128: Use `https://` submodule urls. [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/java-interop/62/console
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building xamarin-android/master with Mono 4.4.0 0 would result in a
build error within
src/Mono.Posix:This was introduced by commit f2fed37, which added
System.Runtimeas a
@(Reference)toMono.Posix.csproj.Mono.Posix.csproj<Import/>sXamarin.Android.CSharp.targets,which indirectly adds
System.Runtime, so there is no need forMono.Posix.csprojto directly refernceSystem.Runtime.Additionally,
msbuildis more stringent regarding property functionsand quoting: this resulted in an MSBuild error:
The fix is to properly quote the
.Contains()method parameters.Finally, re-order various elements to increase consistency with other
projects, e.g.
@(Reference)should go with other@(Reference)entries,
Configuration.propsshould be imported as early aspossible,
$(TargetFrameworkVersion)should be set to$(AndroidFrameworkVersion)(which requires the earlirerConfiguration.propsimport), etc.