[Xamarin.Android.Build.Tasks] skip C# binding-related targets #6399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1334066 In traditional Xamarin.Android, a File -> New binding project emits the warning: BINDINGSGENERATOR warning BG8601: No '<package>' elements found. This happens until you add a Java library to actually bind. The warning doesn't happen in .NET 6 due to the `Condition`: <Target Name="_SetAndroidGenerateManagedBindings" Condition=" '$(UsingAndroidNETSdk)' != 'true' Or '@(InputJar->Count())' != '0' Or '@(EmbeddedJar->Count())' != '0' Or '@(LibraryProjectZip->Count())' != '0' "> <PropertyGroup> <!-- Used throughout to determine if C# binding-related targets should skip --> <_AndroidGenerateManagedBindings>true</_AndroidGenerateManagedBindings> </PropertyGroup> </Target> The `$(UsingAndroidNETSdk)` check makes the value always true in traditional Xamarin.Android. I think we can just remove this check, as the `Condition` has been working well in .NET 6. I added a new test for this scenario. The warning is gone now.
jpobst
approved these changes
Oct 18, 2021
dellis1972
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1334066
In traditional Xamarin.Android, a File -> New binding project emits
the warning:
This happens until you add a Java library to actually bind.
The warning doesn't happen in .NET 6 due to the
Condition:The
$(UsingAndroidNETSdk)check makes the value always true intraditional Xamarin.Android. I think we can just remove this check, as
the
Conditionhas been working well in .NET 6.I added a new test for this scenario. The warning is gone now.