[One .NET] extend the microsoft-net-runtime-android workload #5975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/dotnet/runtime/blob/d43e88620fe574045f026a4ebce50f7a8541347a/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.json.in In order to start using packs from the `microsoft-net-runtime-android` workload, we need to: 1. Add `Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100` to `package-download.proj`. 2. Copy `WorkloadManifest.*` files from: Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100/data/ To: ~/android-toolchain/dotnet/sdk-manifests/6.0.100/Microsoft.NET.Workload.Mono.ToolChain/ So we get the latest `WorkloadManifest.json` based on the version defined in `$(MicrosoftNETCoreAppRefPackageVersion)`. 3. `xaprepare` should run: ~/android-toolchain/dotnet/dotnet workload install microsoft-net-runtime-android --skip-manifest-update --verbosity diag So the packs are installed for local development and CI. 4. Our workload should "extend" `microsoft-net-runtime-android`. This would make sure these packs are installed on user's machines.
grendello
approved these changes
May 31, 2021
dellis1972
approved these changes
Jun 1, 2021
Member
Author
|
I think the test failures look OK, designer tests are known to be broken right now as well as Going to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/dotnet/runtime/blob/d43e88620fe574045f026a4ebce50f7a8541347a/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.json.in
In order to start using packs from the
microsoft-net-runtime-androidworkload, we need to:
Add
Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100topackage-download.proj.Copy
WorkloadManifest.*files from:To:
So we get the latest
WorkloadManifest.jsonbased on the versiondefined in
$(MicrosoftNETCoreAppRefPackageVersion).xaprepareshould run:So the packs are installed for local development and CI.
microsoft-net-runtime-android. Thiswould make sure these packs are installed on user's machines.