[Xamarin.Android.Build.Tasks] bump XA0113 warning to 29 #5351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Dec 2, 2020
Contributor
dellis1972
left a comment
dellis1972
left a comment
There was a problem hiding this comment.
This looks good.
I do wonder though, if we should change the text so that we pass in the values for the expected TargetFramework and API Level... That way we don't have to re-translate the text every time we bump this.
Member
Author
Yes, I think this should probably use additional |
Fixes: dotnet#4977 Context: https://support.google.com/googleplay/android-developer/answer/9859152?visit_id=637424522037563363-1219346479&rd=1#targetsdk We currently warn if `$(TargetFrameworkVersion)` is less than 28: Google Play requires that new applications and updates must use a TargetFrameworkVersion of v9.0 (API level 28) or above. Since November 2, 2020, Google Play requires API 29, so we need to update this warning.
jonathanpeppers
force-pushed
the
google-play-api-29
branch
from
bc20381 to
6ef0168
Compare
dellis1972
approved these changes
Dec 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4977
Context: https://support.google.com/googleplay/android-developer/answer/9859152?visit_id=637424522037563363-1219346479&rd=1#targetsdk
We currently warn if
$(TargetFrameworkVersion)is less than 28:Since November 2, 2020, Google Play requires API 29, so we need to
update this warning.